Difference between revisions of "Medmasterpro API Review"

From OpenEMR Project Wiki
Line 11: Line 11:
:* Surround the entire $device_token_badge with the 'push_notification' global switch.
:* Surround the entire $device_token_badge with the 'push_notification' global switch.
:* In $strQuery suery, need single quotes around the add_escape_custom($patientId)
:* In $strQuery suery, need single quotes around the add_escape_custom($patientId)
:* All the getUserData() function does is return two separate but identical variables with the getUsername() function. Please clean this up a bit, since it appears all you need is a $user = getUsername($userId) and no need for the other variables (emr/password/username).
:* All the getUserData() function does is return two separate but identical variables with the getUsername() function. Please clean this up, since it appears all you need is a $user = getUsername($userId) and no need for the other variables (emr/password/username).
:* Setting $_SESSION['authGroup'] incorrectly. Check out how it is set in library/auth.inc and set it that way. (note I don't even see where this is used in this script)
:* Use the InsertEvent() function in library/encounter_events.inc.php to create the appointment.


==addcheckout.php==
==addcheckout.php==

Revision as of 00:01, 17 March 2013

Overview

This is too review the Medmasterpro api code at http://github.com/medmasterpro/openemr . It gets it's own wiki page because it is an extensive and exciting ongoing project.

Functions

Overview

These are all in the api directory.

Global Issues

  • Change the 'push_notification' global to something more specific like 'device_push_notification_service'

Core functions/scripts in the includes directory

addappointment.php

  • Surround the entire $device_token_badge with the 'push_notification' global switch.
  • In $strQuery suery, need single quotes around the add_escape_custom($patientId)
  • All the getUserData() function does is return two separate but identical variables with the getUsername() function. Please clean this up, since it appears all you need is a $user = getUsername($userId) and no need for the other variables (emr/password/username).
  • Setting $_SESSION['authGroup'] incorrectly. Check out how it is set in library/auth.inc and set it that way. (note I don't even see where this is used in this script)
  • Use the InsertEvent() function in library/encounter_events.inc.php to create the appointment.

addcheckout.php

addcontactgeneral.php

addfacility.php

addfeesheet.php

addinsurancecompany.php

addlist.php

addonotes.php

addpatientdocument.php

addpatientdocumentwithlink.php

addpatientnotes.php

addpatient.php

addpayment.php

addprescription.php

addresource.php

addresourcewithlink.php

addreviewofsystems.php

addroschecks.php

addsoap.php

addvisit.php

addvisitvitals.php

classes.php

  • The site variable will need to be dealt with at some point. Can do this later int he review process after have a better idea of the code flow.

deleteappointment.php

deletecontactgeneral.php

deletefeesheet.php

deletemessage.php

deletepatientdocument.php

deleteprescription.php

deleteresource.php

deletesoap.php

deletevisit.php

forgetpassword.php

getallpatients.php

getappointmentcategories.php

getcontactgeneral.php

getfacility.php

getfeesheetoptions.php

getfeesheet.php

getinsurancecompanies.php

getinsurancecompany.php

getlistbyvisitid.php

getlist.php

getlocation.php

getmessages.php

getnotifications.php

getonotes.php

getpatientdocuments.php

getpatientrecord.php

getprescription.php

getproviders.php

getresources.php

getreviewofsystemsbyid.php

getreviewofsystemslist.php

getreviewofsystems.php

getreviewofsystemssummary.php

getroschecksbyid.php

getroscheckslist.php

getroschecks.php

getroscheckssummary.php

getsendmessages.php

getsoaplist.php

getsoap.php

getstatsoptions.php

getuserlist.php

getvisits.php

getvitals.php

login.php

loginwithpin.php

register.php

report_appointments.php

report_appt_visits.php

report_visits.php

resetpasswordpin.php

searchappointments.new.php

searchappointments.php

searchdiagnosiscode.php

searchdrug.php

searchpatient.php

searchrx.php

sendmessage.php

updateappointment.php

updatecontactgeneral.php

updatefacility.php

updatefeesheet.php

updateinsurancecompany.php

updatelist.php

updatelocation.php

updatenotificationbadge.php

updatepatientdocument.php

updatepatientnotes.php

updatepatient.php

updateprescription.php

updateprofileimage.php

updatereviewofsystems.php

updateroschecks.php

updatesoap.php

updatevisit.php

updatevisitvitals.php

version_openemr.php

version.php

visitsummery.php